From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbVh8-0002Zj-Tx for qemu-devel@nongnu.org; Thu, 22 Nov 2012 07:15:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbVh2-0000Rp-4D for qemu-devel@nongnu.org; Thu, 22 Nov 2012 07:15:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbVh1-0000Rk-RE for qemu-devel@nongnu.org; Thu, 22 Nov 2012 07:15:44 -0500 Message-ID: <50AE1768.4010604@redhat.com> Date: Thu, 22 Nov 2012 13:15:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1353522781-12721-1-git-send-email-stefanha@redhat.com> <1353522781-12721-10-git-send-email-stefanha@redhat.com> <50ADF195.4030204@redhat.com> <20121122115823.GA13571@stefanha-thinkpad.redhat.com> In-Reply-To: <20121122115823.GA13571@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 09/12] iov: add iov_get_ptr() to reference vector data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Anthony Liguori , dkoch@cloudswitch.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Michael Roth , Blue Swirl , khoa@us.ibm.com, Asias He Il 22/11/2012 12:58, Stefan Hajnoczi ha scritto: > Then we can pass the iovec[] array straight to > the Linux AIO functions. > > Since I knew the inhdr is only 1 byte I decided against doing something > like dynamically allocating/freeing a QEMUIOVector which could handle > spanning iovecs. Long-term we want anyway a QEMUIOVector, to pass it to block functions. Can you introduce qemu_iovec_concat_iov that takes an iov/niov pair instead of the source QEMUIOVector? That should do quite nicely. Paolo