From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbZzK-0004W9-Id for qemu-devel@nongnu.org; Thu, 22 Nov 2012 11:50:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbZzH-0004QI-4r for qemu-devel@nongnu.org; Thu, 22 Nov 2012 11:50:54 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:60416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbZzG-0004Pr-Js for qemu-devel@nongnu.org; Thu, 22 Nov 2012 11:50:51 -0500 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Nov 2012 02:47:14 +1000 Message-ID: <50AE57DE.2090407@linux.vnet.ibm.com> Date: Fri, 23 Nov 2012 00:50:38 +0800 From: Li Zhang MIME-Version: 1.0 References: <50AE540A.3040107@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , Alexander Graf , qemu-devel qemu-devel , Blue Swirl , "qemu-ppc@nongnu.org List" , "zhlcindy@gmail.com" , Aurelien Jarno On 2012年11月23日 00:49, Peter Maydell wrote: > On 22 November 2012 16:39, Peter Maydell wrote: >> We use "-usb" to enable USB in this command line. That has >> to continue to work, for back compatibility. I think your >> code to try to support -usb is broken: >> case QEMU_OPTION_usb: >> machine_opts = qemu_opts_find(qemu_find_opts("machine"), 0); >> >> will return NULL if there are no user-set machine opts >> at this point, so we never go on to try to set the usb >> machine opt to true. > Patch sent which fixes this bug. Thanks for fixing that. :) > > -- PMM > -- Li Zhang IBM China Linux Technology Centre