From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbpMs-0000SQ-3d for qemu-devel@nongnu.org; Fri, 23 Nov 2012 04:16:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbpMi-0003Jx-0g for qemu-devel@nongnu.org; Fri, 23 Nov 2012 04:16:13 -0500 Received: from mail-ia0-f173.google.com ([209.85.210.173]:56347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbpMh-0003Jm-S3 for qemu-devel@nongnu.org; Fri, 23 Nov 2012 04:16:03 -0500 Received: by mail-ia0-f173.google.com with SMTP id w21so4872912iac.4 for ; Fri, 23 Nov 2012 01:16:02 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50AF3ECA.2060200@redhat.com> Date: Fri, 23 Nov 2012 10:15:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1353488464-82756-1-git-send-email-dietmar@proxmox.com> <50ACB184.5080204@redhat.com> <24E144B8C0207547AD09C467A8259F755782D8A1@lisa.maurer-it.com> <50ACCAEC.2030001@redhat.com> <50ACD5BC.2080006@redhat.com> <24E144B8C0207547AD09C467A8259F755782F867@lisa.maurer-it.com> <24E144B8C0207547AD09C467A8259F755782F985@lisa.maurer-it.com> <24E144B8C0207547AD09C467A8259F755782F9A4@lisa.maurer-it.com> In-Reply-To: <24E144B8C0207547AD09C467A8259F755782F9A4@lisa.maurer-it.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dietmar Maurer Cc: Kevin Wolf , "qemu-devel@nongnu.org" Il 23/11/2012 10:05, Dietmar Maurer ha scritto: >>>> My plan was to have something like bs->job->job_type- >>>> {before,after}_write. >>>> >>>> int coroutine_fn (*before_write)(BlockDriverState *bs, >>>> int64_t sector_num, int nb_sectors, QEMUIOVector *qiov, >>>> void **cookie); >>>> int coroutine_fn (*after_write)(BlockDriverState *bs, >>>> int64_t sector_num, int nb_sectors, QEMUIOVector *qiov, >>>> void *cookie); >>> >>> I don't think that job is the right place. Instead I would put a list >>> of filters into >>> BDS: >> >> Well, I can also add it to job_type. Just tell me what you prefer, and I will >> write the patch. > > BTW, will such filters work with the new virtio-blk-data-plane? No, virtio-blk-data-plane is a hack and will be slowly rewritten to support all fancy features. Paolo