From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59221)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TbuAO-00045I-OH
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:23:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TbuAK-00066R-KB
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:23:40 -0500
Received: from greensocs.com ([87.106.252.221]:60520
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1TbuAK-00066N-Dy
	for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:23:36 -0500
Message-ID: <50AF86F7.5070508@greensocs.com>
Date: Fri, 23 Nov 2012 15:23:51 +0100
From: Konrad Frederic <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1353595852-30776-1-git-send-email-fred.konrad@greensocs.com>
	<1353595852-30776-3-git-send-email-fred.konrad@greensocs.com>
	<20121123122941.GA29800@stefanha-thinkpad.redhat.com>
	<CAFEAcA_a_gocpeRObav5WoWRdHF4Fsb7BHeuAA2qytFhNHEy+A@mail.gmail.com>
In-Reply-To: <CAFEAcA_a_gocpeRObav5WoWRdHF4Fsb7BHeuAA2qytFhNHEy+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus
	interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, cornelia.huck@de.ibm.com, afaerber@suse.de

On 23/11/2012 13:34, Peter Maydell wrote:
> On 23 November 2012 12:29, Stefan Hajnoczi<stefanha@redhat.com>  wrote:
>> On Thu, Nov 22, 2012 at 03:50:51PM +0100, fred.konrad@greensocs.com wrote:
>>> +static const struct VirtioBusInfo virtio_bus_info = {
>>> +    .init_cb = virtio_pci_init_cb,
>>> +    .exit_cb = virtio_pci_exit_cb,
>>> +
>>> +    .virtio_bindings = {
>> Eventually VirtIOBindings can probably be inlined into VirtioBusInfo.  I
>> don't see a need for separate structs.
> I agree. It might (or might not) be convenient to retain it
> temporarily while converting all the transports, but
> VirtIOBindings is part of the old code which we're trying
> to refactor here, and I'd expect it to go away when we're done.
>
> -- PMM
Yes, for the moment, I didn't refactor this VirtIOBindings, so it is 
better to separate struct to keep the virtiodevice binding function.