qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Frederic <fred.konrad@greensocs.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
	e.voevodin@samsung.com, mark.burton@greensocs.com,
	qemu-devel@nongnu.org, cornelia.huck@de.ibm.com,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] Virtio-refactoring.
Date: Fri, 23 Nov 2012 15:29:52 +0100	[thread overview]
Message-ID: <50AF8860.2070102@greensocs.com> (raw)
In-Reply-To: <20121123123803.GC29800@stefanha-thinkpad.redhat.com>

On 23/11/2012 13:38, Stefan Hajnoczi wrote:
> On Thu, Nov 22, 2012 at 03:50:49PM +0100, fred.konrad@greensocs.com wrote:
>> From: KONRAD Frederic<fred.konrad@greensocs.com>
>> I made the changes you suggest in the last RFC.
>>
>> There are still two issues with the command line :
>>
>>      * When I use ./qemu* -device virtio-blk -device virtio-pci
>>        It is said that no virtio-bus are present.
>>      * The virtio-blk is plugged in the last created virtio-bus if no "bus="
>>        option is present. It's an issue as we can only plug one virtio-device.
>>
>> The first problem is a more general issue as it is the case for the SCSI bus and
>> can be fixed later.
> Thanks for sharing virtio refactoring progress.
>
> I think the challenge will be truly converting existing code over to the
> new approach.  This RFC series adds a new layer on top of the existing
> code but doesn't actually replace it.
>
> Would be interesting to see the complete picture, even if you need to
> leave some TODOs in the middle when sending RFC patches.
>
> Stefan
Yes, sure.

So the next would be :
     * use QOM interface in place of VirtioBusInfo ?
     * refactor the VirtIODevice to remove VirtIOBinding ?

I though modifying the less I can the VirtIODevice as it could break all 
the s390 devices.

Fred

  reply	other threads:[~2012-11-23 14:29 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22 14:50 [Qemu-devel] [RFC PATCH v2 0/3] Virtio-refactoring fred.konrad
2012-11-22 14:50 ` [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus fred.konrad
2012-11-23 12:08   ` Cornelia Huck
2012-11-23 14:12     ` Konrad Frederic
2012-11-23 14:35       ` Cornelia Huck
2012-11-26 13:55     ` Konrad Frederic
2012-11-26 14:03       ` Cornelia Huck
2012-11-23 12:23   ` Stefan Hajnoczi
2012-11-23 14:21     ` Konrad Frederic
2012-11-23 16:13       ` Stefan Hajnoczi
2012-11-24 22:29   ` Andreas Färber
2012-11-26 14:33   ` Anthony Liguori
2012-11-26 14:37     ` Peter Maydell
2012-11-26 16:59       ` Anthony Liguori
2012-11-29 12:37         ` Konrad Frederic
2012-11-29 13:09           ` Peter Maydell
2012-11-29 13:47             ` Konrad Frederic
2012-11-29 13:53               ` Peter Maydell
2012-11-29 13:55               ` Andreas Färber
2012-11-29 14:28                 ` Konrad Frederic
2012-11-29 13:52           ` Anthony Liguori
2012-11-26 14:45     ` Andreas Färber
2012-11-26 16:55       ` Anthony Liguori
2012-11-26 15:33     ` Konrad Frederic
2012-11-26 15:40     ` Stefan Hajnoczi
2012-11-22 14:50 ` [Qemu-devel] [RFC PATCH v2 2/3] virtio-pci : add a virtio-bus interface fred.konrad
2012-11-23 12:11   ` Cornelia Huck
2012-11-23 12:29   ` Stefan Hajnoczi
2012-11-23 12:34     ` Peter Maydell
2012-11-23 14:23       ` Konrad Frederic
2012-11-23 14:26         ` Peter Maydell
2012-11-23 14:33           ` Konrad Frederic
2012-11-26 14:43   ` Anthony Liguori
2012-11-22 14:50 ` [Qemu-devel] [RFC PATCH v2 3/3] virtio-blk : add the virtio-blk device fred.konrad
2012-11-23 12:32   ` Stefan Hajnoczi
2012-11-22 15:08 ` [Qemu-devel] [RFC PATCH v2 0/3] Virtio-refactoring Peter Maydell
2012-11-22 15:15   ` KONRAD Frédéric
2012-11-23 12:38 ` Stefan Hajnoczi
2012-11-23 14:29   ` Konrad Frederic [this message]
2012-11-23 16:18     ` Stefan Hajnoczi
2012-11-26  9:00       ` Konrad Frederic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AF8860.2070102@greensocs.com \
    --to=fred.konrad@greensocs.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=e.voevodin@samsung.com \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).