From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbuGI-00075d-6x for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:29:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbuGC-0007zv-6a for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:29:46 -0500 Received: from greensocs.com ([87.106.252.221]:60950 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbuGB-0007zB-W2 for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:29:40 -0500 Message-ID: <50AF8860.2070102@greensocs.com> Date: Fri, 23 Nov 2012 15:29:52 +0100 From: Konrad Frederic MIME-Version: 1.0 References: <1353595852-30776-1-git-send-email-fred.konrad@greensocs.com> <20121123123803.GC29800@stefanha-thinkpad.redhat.com> In-Reply-To: <20121123123803.GC29800@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] Virtio-refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, afaerber@suse.de On 23/11/2012 13:38, Stefan Hajnoczi wrote: > On Thu, Nov 22, 2012 at 03:50:49PM +0100, fred.konrad@greensocs.com wrote: >> From: KONRAD Frederic >> I made the changes you suggest in the last RFC. >> >> There are still two issues with the command line : >> >> * When I use ./qemu* -device virtio-blk -device virtio-pci >> It is said that no virtio-bus are present. >> * The virtio-blk is plugged in the last created virtio-bus if no "bus=" >> option is present. It's an issue as we can only plug one virtio-device. >> >> The first problem is a more general issue as it is the case for the SCSI bus and >> can be fixed later. > Thanks for sharing virtio refactoring progress. > > I think the challenge will be truly converting existing code over to the > new approach. This RFC series adds a new layer on top of the existing > code but doesn't actually replace it. > > Would be interesting to see the complete picture, even if you need to > leave some TODOs in the middle when sending RFC patches. > > Stefan Yes, sure. So the next would be : * use QOM interface in place of VirtioBusInfo ? * refactor the VirtIODevice to remove VirtIOBinding ? I though modifying the less I can the VirtIODevice as it could break all the s390 devices. Fred