From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbuIv-0000ao-ON for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:32:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbuIp-0000GY-Px for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:32:29 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:40132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbuIp-0000GO-HY for qemu-devel@nongnu.org; Fri, 23 Nov 2012 09:32:23 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Nov 2012 14:32:21 -0000 Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qANEWAd154329406 for ; Fri, 23 Nov 2012 14:32:10 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qANEWHdb003626 for ; Fri, 23 Nov 2012 07:32:17 -0700 Message-ID: <50AF88F0.5020209@de.ibm.com> Date: Fri, 23 Nov 2012 15:32:16 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1353665892-35445-1-git-send-email-jfrei@linux.vnet.ibm.com> <1353665892-35445-3-git-send-email-jfrei@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] s390: clear registers, psw and prefix at vcpu reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Heinz Graalfs , qemu-devel , Viktor Mihajlovski , Jens Freimann , Cornelia Huck , Einar Lueck On 23/11/12 14:40, Alexander Graf wrote: > > On 23.11.2012, at 11:18, Jens Freimann wrote: > >> When resetting vcpus on s390/kvm we have to clear registers, psw >> and prefix as described in the z/Architecture PoP, otherwise a >> reboot won't work. IPL PSW and prefix are set later on by the >> s390-ipl device reset code. >> >> Signed-off-by: Jens Freimann >> --- >> target-s390x/kvm.c | 26 +++++++++++++++++++++++++- >> 1 file changed, 25 insertions(+), 1 deletion(-) >> >> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c >> index 94de764..b1b791e 100644 >> --- a/target-s390x/kvm.c >> +++ b/target-s390x/kvm.c > > This needs to go into generic vcpu reset code. The kvm ioctl certainly not, no? (definitely necessary for kernels without sync regs). I guess you are talking about moving the register initialisation into s390_cpu_reset (target-s390x/cpu.c). Right? Jens can you have a look? Christian