From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbx6u-0005SS-8Z for qemu-devel@nongnu.org; Fri, 23 Nov 2012 12:32:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tbx6q-0006Ch-BP for qemu-devel@nongnu.org; Fri, 23 Nov 2012 12:32:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbx6q-0006Cb-3i for qemu-devel@nongnu.org; Fri, 23 Nov 2012 12:32:12 -0500 Message-ID: <50AFB316.6010004@redhat.com> Date: Fri, 23 Nov 2012 18:32:06 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1353660436-8897-1-git-send-email-pbonzini@redhat.com> <1353660436-8897-6-git-send-email-pbonzini@redhat.com> <50AFAE70.9070501@suse.de> In-Reply-To: <50AFAE70.9070501@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1.3 5/5] qom: make object_finalize static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, Liu Ping Fan Il 23/11/2012 18:12, Andreas F=E4rber ha scritto: > We have not yet started using the in-place mechanism much (i440fx and > prep_pci patches, not in master; also my tegra branch), so I would like > to keep this for symmetry with "initialize" vs. "new" and their > distinguished semantics. But you do not need it anymore. When the last reference disappears, everything is finalized. So you just use ref/unref. Delete is simply unparent+unref, and applies just as well to objects that were initialized in place. The point of patch 3 is to get rid of the distinction between initialize and new. That distinction just shouldn't be there if you have reference counting. > It is not a bugfix anyway, so not needed for 1.3. Fair enough. Paolo