From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tch17-0008Aj-1t
	for qemu-devel@nongnu.org; Sun, 25 Nov 2012 13:33:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tch16-0004Xd-0c
	for qemu-devel@nongnu.org; Sun, 25 Nov 2012 13:33:20 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39038 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tch15-0004XX-QK
	for qemu-devel@nongnu.org; Sun, 25 Nov 2012 13:33:19 -0500
Message-ID: <50B26468.8000908@suse.de>
Date: Sun, 25 Nov 2012 19:33:12 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1353598263-13097-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1353598263-13097-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for 1.3] target-i386: cpu: add missing
 flags to Haswell CPU model
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, donald.d.dugger@intel.com, Anthony Liguori <anthony@codemonkey.ws>, Martin Kletzander <mkletzan@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>

Am 22.11.2012 16:31, schrieb Eduardo Habkost:
> When adding the Haswell CPU model, I intended to make it a superset of =
the
> features present on the SandyBridge model, but I have removed the SEP a=
nd
> RDTSCP features from the feature list by mistake. This patch adds the m=
issing
> SEP and RDTSCP features (that are present on SandyBridge) to Haswell.
>=20
> Reported-by: Martin Kletzander <mkletzan@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Acked-by: Andreas F=E4rber <afaerber@suse.de>

FWIW this is showing where QOM's imperative approach combined with
inheritance could greatly simplify things beyond your subclasses RFC.
Unfortunately I am not intimately familiar with all these models, so
counting on your help there. :)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg