From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] buffered_file: rate-limit producers based on buffer size
Date: Mon, 26 Nov 2012 09:17:42 +0100 [thread overview]
Message-ID: <50B325A6.3090701@redhat.com> (raw)
In-Reply-To: <CAAu8pHuR0DHt0Wn_87NOS-wOM9_WxV2qKirnjjkrbCZM7YQ3Qg@mail.gmail.com>
Il 24/11/2012 20:53, Blue Swirl ha scritto:
>> > - if (s->bytes_xfer > s->xfer_limit)
>> > + if (s->buffer_size >= s->xfer_limit)
> Please add braces.
Frankly I don't care much. This code is going to disappear at the
beginning of 1.4.
Paolo
>> > return 1;
>> >
next prev parent reply other threads:[~2012-11-26 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 16:45 [Qemu-devel] [PATCH v2 0/4] migration: fix rate limiting Paolo Bonzini
2012-11-20 16:45 ` [Qemu-devel] [PATCH v2 1/4] buffered_file: reset bytes_xfer on every tick Paolo Bonzini
2012-11-20 16:45 ` [Qemu-devel] [PATCH v2 2/4] buffered_file: do not send more than s->bytes_xfer bytes per tick Paolo Bonzini
2012-11-20 16:45 ` [Qemu-devel] [PATCH v2 3/4] buffered_file: rate-limit producers based on buffer size Paolo Bonzini
2012-11-24 19:53 ` Blue Swirl
2012-11-26 8:17 ` Paolo Bonzini [this message]
2012-11-20 16:45 ` [Qemu-devel] [PATCH v2 4/4] buffered_file: do not automatically unfreeze output on buffered_put_buffer Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B325A6.3090701@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).