From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Tctt4-0004ue-0R
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 03:17:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Tctsy-0008It-69
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 03:17:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13524)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Tctsx-0008Ik-Uh
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 03:17:48 -0500
Message-ID: <50B325A6.3090701@redhat.com>
Date: Mon, 26 Nov 2012 09:17:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1353429936-29180-1-git-send-email-pbonzini@redhat.com>
	<1353429936-29180-4-git-send-email-pbonzini@redhat.com>
	<CAAu8pHuR0DHt0Wn_87NOS-wOM9_WxV2qKirnjjkrbCZM7YQ3Qg@mail.gmail.com>
In-Reply-To: <CAAu8pHuR0DHt0Wn_87NOS-wOM9_WxV2qKirnjjkrbCZM7YQ3Qg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/4] buffered_file: rate-limit producers
 based on buffer size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

Il 24/11/2012 20:53, Blue Swirl ha scritto:
>> > -    if (s->bytes_xfer > s->xfer_limit)
>> > +    if (s->buffer_size >= s->xfer_limit)
> Please add braces.

Frankly I don't care much.  This code is going to disappear at the
beginning of 1.4.

Paolo

>> >          return 1;
>> >