From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57656)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TcxFB-00011B-1b
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 06:52:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TcxF3-0002vL-5m
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 06:52:56 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39561 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TcxF2-0002vE-Va
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 06:52:49 -0500
Message-ID: <50B3580B.6040207@suse.de>
Date: Mon, 26 Nov 2012 12:52:43 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1353888766-6951-1-git-send-email-afaerber@suse.de>
	<1353888766-6951-2-git-send-email-afaerber@suse.de>
	<50B3185A.3080005@redhat.com>
In-Reply-To: <50B3185A.3080005@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/34] qdev: Eliminate qdev_free() in favor
	of QOM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Am 26.11.2012 08:20, schrieb Paolo Bonzini:
> Il 26/11/2012 01:12, Andreas F=C3=A4rber ha scritto:
>> qdev_free() was trivially wrapping object_delete(). Inline it and drop
>> the wrapper as a further step to QOM'ify qdev.
>=20
> The reference counts of devices and buses are completely disconnected
> from reality, and that's why object_delete() works.
>=20
> I'd prefer this patch not to be applied until this is straightened out.=
..

Your series is marked for-1.3 whereas this is for 1.4, so no obvious
problem there - wanted to mention the overlap in the cover letter but
apparently forgot.

My quest was to kill obsolete things with old "qdev" in the name. :)
I don't really mind if this becomes object_delete() or object_unref() or
anything else as long as it's not such a trivial qdev_* wrapper calling
one QOM object_* function.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg