From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td116-000878-U0 for qemu-devel@nongnu.org; Mon, 26 Nov 2012 10:54:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Td112-0005VN-Vp for qemu-devel@nongnu.org; Mon, 26 Nov 2012 10:54:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td112-0005VD-OY for qemu-devel@nongnu.org; Mon, 26 Nov 2012 10:54:36 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAQFsZRP026911 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Nov 2012 10:54:35 -0500 Message-ID: <50B390BA.6050700@redhat.com> Date: Mon, 26 Nov 2012 16:54:34 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <28e9cb8033528aceee73614d8231c0786704df88.1353943996.git.phrdina@redhat.com> In-Reply-To: <28e9cb8033528aceee73614d8231c0786704df88.1353943996.git.phrdina@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/1] atapi: make change media detection for guests easier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org Am 26.11.2012 16:37, schrieb Pavel Hrdina: > If you have a guest with a media in the optical drive and you change > it, the windows guest cannot properly recognize this media change. > > Windows needs to detect sense "NOT_READY with ASC_MEDIUM_NOT_PRESENT" > before we send sense "UNIT_ATTENTION with ASC_MEDIUM_MAY_HAVE_CHANGED". > > v4: - removed fake_cdrom_changed introduced in v3 > - cleaned ide_drive_post_load > > v3: - remove timeout as it isn't needed anymore > > v2: - disable debug messages > > Signed-off-by: Pavel Hrdina Thanks, applied to the block branch for 1.3. Kevin