From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49004)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Td1T7-0005XC-0G
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 11:23:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Td1T6-00064h-1T
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 11:23:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60113)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Td1T5-00063u-Pj
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 11:23:35 -0500
Message-ID: <50B3976D.9030804@redhat.com>
Date: Mon, 26 Nov 2012 17:23:09 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1351073447-643298-1-git-send-email-dietmar@proxmox.com>
	<50ACD600.9020102@redhat.com>
In-Reply-To: <50ACD600.9020102@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] stream: fix ratelimit_set_speed
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Dietmar Maurer <dietmar@proxmox.com>

Am 21.11.2012 14:24, schrieb Paolo Bonzini:
> Il 24/10/2012 12:10, Dietmar Maurer ha scritto:
>> The formula to compute slice_quota was wrong.
>>
>> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
>> ---
>>  include/qemu/ratelimit.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/qemu/ratelimit.h b/include/qemu/ratelimit.h
>> index c6ac281..d1610f1 100644
>> --- a/include/qemu/ratelimit.h
>> +++ b/include/qemu/ratelimit.h
>> @@ -42,7 +42,7 @@ static inline void ratelimit_set_speed(RateLimit *limit, uint64_t speed,
>>                                         uint64_t slice_ns)
>>  {
>>      limit->slice_ns = slice_ns;
>> -    limit->slice_quota = ((double)speed * 1000000000ULL) / slice_ns;
>> +    limit->slice_quota = ((double)speed * slice_ns)/1000000000ULL;
>>  }
>>  
>>  #endif
>>
> 
> Ping... Stefan, can you commit this fix to block branch too?

Thanks, applied to the block branch for 1.3.

Kevin