From: Gerd Hoffmann <kraxel@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman
Date: Mon, 26 Nov 2012 21:04:53 +0100 [thread overview]
Message-ID: <50B3CB65.10601@redhat.com> (raw)
In-Reply-To: <1353955943-26536-1-git-send-email-agraf@suse.de>
Hi,
> Guard the PIXMAN_TYPE_BGRA branch like in the case right above the failing
> case, so that compilation is fixed. Functionality on such old pixman is a
> different question ;-).
> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8)
> type = PIXMAN_TYPE_BGRA;
> +#endif
Version is wrong, on 0.18.4 this builds just fine, so PIXMAN_TYPE_BGRA
must be older than that.
I'd also tend to just change the check in configure instead and ignore
system pixman in case it is too old.
cheers,
Gerd
next prev parent reply other threads:[~2012-11-26 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 18:52 [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman Alexander Graf
2012-11-26 20:04 ` Gerd Hoffmann [this message]
2012-11-26 20:09 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B3CB65.10601@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).