From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td4vL-0000oP-P1 for qemu-devel@nongnu.org; Mon, 26 Nov 2012 15:05:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Td4vK-0006DQ-Me for qemu-devel@nongnu.org; Mon, 26 Nov 2012 15:04:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td4vK-0006DL-EZ for qemu-devel@nongnu.org; Mon, 26 Nov 2012 15:04:58 -0500 Message-ID: <50B3CB65.10601@redhat.com> Date: Mon, 26 Nov 2012 21:04:53 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1353955943-26536-1-git-send-email-agraf@suse.de> In-Reply-To: <1353955943-26536-1-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "qemu-devel@nongnu.org qemu-devel" , Anthony Liguori Hi, > Guard the PIXMAN_TYPE_BGRA branch like in the case right above the failing > case, so that compilation is fixed. Functionality on such old pixman is a > different question ;-). > +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8) > type = PIXMAN_TYPE_BGRA; > +#endif Version is wrong, on 0.18.4 this builds just fine, so PIXMAN_TYPE_BGRA must be older than that. I'd also tend to just change the check in configure instead and ignore system pixman in case it is too old. cheers, Gerd