Re: [Qemu-devel] [PATCH V4] target-i386: Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs

["Andreas Färber" <afaerber@suse.de>]

Am 27.11.2012 03:29, schrieb Will Auld:
> CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported
> 
> Basic design is to emulate the MSR by allowing reads and writes to the
> hypervisor vcpu specific locations to store the value of the emulated MSRs.
> In this way the IA32_TSC_ADJUST value will be included in all reads to
> the TSC MSR whether through rdmsr or rdtsc.
> 
> As this is a new MSR that the guest may access and modify its value needs
> to be migrated along with the other MRSs. The changes here are specifically
> for recognizing when IA32_TSC_ADJUST is enabled in CPUID and code added
> for migrating its value.
> 
> Signed-off-by: Will Auld <will.auld@intel.com>

Better, but problems remain (not sure about line endings, didn't check
before). It seems the tabs got more rather than getting replaced with
four spaces. (And QEMU regressed to Qemu.)

For future patches you may find the following helpful to detect formal
errors early yourself (git commit --no-verify overrides):
http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html

Regards,
Andreas

$ scripts/checkpatch.pl ../wauld_tsc_adjust_v4.eml
ERROR: DOS line endings
#129: FILE: target-i386/cpu.h:287:
+#define MSR_TSC_ADJUST^I^I^I0x0000003b^M$

ERROR: code indent should never use tabs
#129: FILE: target-i386/cpu.h:287:
+#define MSR_TSC_ADJUST^I^I^I0x0000003b^M$

ERROR: DOS line endings
[...]

ERROR: code indent should never use tabs
#157: FILE: target-i386/kvm.c:645:
+^I^Iif (kvm_msr_list->indices[i] == MSR_TSC_ADJUST) {^M$

ERROR: DOS line endings
#158: FILE: target-i386/kvm.c:646:
+^I^I    has_msr_tsc_adjust = true;^M$

ERROR: code indent should never use tabs
#158: FILE: target-i386/kvm.c:646:
+^I^I    has_msr_tsc_adjust = true;^M$

[...]

total: 48 errors, 0 warnings, 91 lines checked

../wauld_tsc_adjust_v4.eml has style problems, please review.  [...]

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg