From: Paolo Bonzini <pbonzini@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com
Subject: Re: [Qemu-devel] [PATCH V11 4/7] libqblock build system
Date: Tue, 27 Nov 2012 10:09:28 +0100 [thread overview]
Message-ID: <50B48348.4080102@redhat.com> (raw)
In-Reply-To: <50B42E5F.4030607@linux.vnet.ibm.com>
Il 27/11/2012 04:07, Wenchao Xia ha scritto:
>>
>> Please move this file to patch 6. I had a big "WTF" wondering how this
>> could work :) before seeing that you then modified it in patch 6.
>>
> OK to move it, but have a little problem, if it is removed then
> this patch will fail in compile because symbol missing.
Ok, can you do the opposite then? That is, include the complete
implementation here in patch 4.
If not, it's okay to keep it as is.
Paolo
next prev parent reply other threads:[~2012-11-27 9:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-24 9:27 [Qemu-devel] [PATCH V11 0/7] libqblock qemu block layer library Wenchao Xia
2012-11-24 9:27 ` [Qemu-devel] [PATCH V11 1/7] Build system fix distclean error for pixman Wenchao Xia
2012-11-24 21:02 ` Blue Swirl
2012-11-24 9:27 ` [Qemu-devel] [PATCH V11 2/7] Build system clean tests directory clearly Wenchao Xia
2012-11-24 9:27 ` [Qemu-devel] [PATCH V11 3/7] block export function path_has_protocol Wenchao Xia
2012-11-24 9:27 ` [Qemu-devel] [PATCH V11 4/7] libqblock build system Wenchao Xia
2012-11-26 7:36 ` Paolo Bonzini
2012-11-27 3:07 ` Wenchao Xia
2012-11-27 9:09 ` Paolo Bonzini [this message]
2012-11-24 9:27 ` [Qemu-devel] [PATCH V11 5/7] libqblock API design and type defines Wenchao Xia
2012-11-24 9:27 ` [Qemu-devel] [PATCH V11 6/7] libqblock API implement Wenchao Xia
2012-11-26 8:34 ` Paolo Bonzini
2012-11-27 3:22 ` Wenchao Xia
2012-11-27 9:11 ` Paolo Bonzini
2012-11-24 9:27 ` [Qemu-devel] [PATCH V11 7/7] libqblock test example Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B48348.4080102@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).