From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdHCM-0002EV-IX for qemu-devel@nongnu.org; Tue, 27 Nov 2012 04:11:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdHCL-0000FG-Hc for qemu-devel@nongnu.org; Tue, 27 Nov 2012 04:11:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdHCL-0000FC-9p for qemu-devel@nongnu.org; Tue, 27 Nov 2012 04:11:21 -0500 Message-ID: <50B48348.4080102@redhat.com> Date: Tue, 27 Nov 2012 10:09:28 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1353749244-25676-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1353749244-25676-5-git-send-email-xiawenc@linux.vnet.ibm.com> <50B31BFE.5040700@redhat.com> <50B42E5F.4030607@linux.vnet.ibm.com> In-Reply-To: <50B42E5F.4030607@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V11 4/7] libqblock build system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com Il 27/11/2012 04:07, Wenchao Xia ha scritto: >> >> Please move this file to patch 6. I had a big "WTF" wondering how this >> could work :) before seeing that you then modified it in patch 6. >> > OK to move it, but have a little problem, if it is removed then > this patch will fail in compile because symbol missing. Ok, can you do the opposite then? That is, include the complete implementation here in patch 4. If not, it's okay to keep it as is. Paolo