qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization
Date: Tue, 27 Nov 2012 17:27:44 +0800	[thread overview]
Message-ID: <50B48790.8030705@linux.vnet.ibm.com> (raw)
In-Reply-To: <1354005361-17805-1-git-send-email-pbonzini@redhat.com>

> Some versions of GCC require insane (>2GB) amounts of memory
> to compile translate.o.  As a countermeasure, compile it
> with -O1.  This should fix the buildbot failure for
> default_x86_64_fedora16.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   Makefile.target | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile.target b/Makefile.target
> index 8b658c0..3981931 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -143,6 +143,8 @@ GENERATED_HEADERS += hmp-commands.h qmp-commands-old.h
> 
>   endif # CONFIG_SOFTMMU
> 
> +%/translate.o: CFLAGS := $(patsubst -O2,-O1,$(CFLAGS))
> +
>   nested-vars += obj-y
> 
>   # This resolves all nested paths, so it must come last
> 
  In tcg case I think translate.o will influent performance obviously,
how about adding an option "fast-build" to use -O1 for it by default.
If you agree I will adding that after this patch upstream which fix
build bot failure quickly.

-- 
Best Regards

Wenchao Xia

  reply	other threads:[~2012-11-27  9:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27  8:36 [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization Paolo Bonzini
2012-11-27  9:27 ` Wenchao Xia [this message]
2012-11-27  9:37   ` Paolo Bonzini
2012-11-27 12:09     ` Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2012-11-27  8:34 Paolo Bonzini
2012-11-27 13:24 ` Peter Maydell
2012-11-27 13:45   ` Gerd Hoffmann
2012-11-27 13:46     ` Peter Maydell
2012-11-27 14:10       ` Paolo Bonzini
2012-11-27 13:49     ` 陳韋任 (Wei-Ren Chen)
2012-11-27 15:05       ` Paolo Bonzini
2012-11-27 16:24       ` Andreas Färber
2012-11-27 15:53 ` Avi Kivity
2012-11-27 16:02   ` Paolo Bonzini
2012-11-27 16:49   ` Markus Armbruster
2012-11-27 16:55     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B48790.8030705@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).