From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdOws-0006K6-R7 for qemu-devel@nongnu.org; Tue, 27 Nov 2012 12:27:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdOwr-0005ha-8D for qemu-devel@nongnu.org; Tue, 27 Nov 2012 12:27:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdOwr-0005gU-0t for qemu-devel@nongnu.org; Tue, 27 Nov 2012 12:27:53 -0500 Message-ID: <50B4EA92.60805@redhat.com> Date: Tue, 27 Nov 2012 17:30:10 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1354033263-32748-1-git-send-email-pbonzini@redhat.com> <50B4E924.109@suse.de> In-Reply-To: <50B4E924.109@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, kraxel@redhat.com Il 27/11/2012 17:24, Alexander Graf ha scritto: >> >> +# Workaround for http://gcc.gnu.org/PR55489. Happens with -fPIE/-fPIC >> +# and large functions that use global variables. The bug is in all >> +# releases of GCC, but it became particularly acute in 4.7.x. We >> +# should be able to delete this at the end of 2013. > > Can we add a version check for gcc here? I don't think it is useful unless somebody finds that the patch gives substantially worse TCG performance. Paolo