qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization
Date: Tue, 27 Nov 2012 17:55:20 +0100	[thread overview]
Message-ID: <50B4F078.6040902@redhat.com> (raw)
In-Reply-To: <87txsb56tk.fsf@blackfin.pond.sub.org>

Il 27/11/2012 17:49, Markus Armbruster ha scritto:
>>> +%/translate.o: CFLAGS := $(patsubst -O2,-O1,$(CFLAGS))
>>> +
>>
>> This may change some string argument in CFLAGS, for example an argument
>> to -I.
>>
>> How about:
>>
>>   CFLAGS_opt = -O2
>>   CFLAGS += $(CFLAGS_opt)
>>   ...
>>   %/translate.o: CFLAGS_opt = -O1
> 
> Just append -O1 to CFLAGS; the last -O wins.

But you don't want to override -O0...

Anyhow, v2 was posted and does it in a different, more fine-grained manner.

Paolo

  reply	other threads:[~2012-11-27 16:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27  8:34 [Qemu-devel] [PATCH 1.3] build: compile translate.o at -O1 optimization Paolo Bonzini
2012-11-27 13:24 ` Peter Maydell
2012-11-27 13:45   ` Gerd Hoffmann
2012-11-27 13:46     ` Peter Maydell
2012-11-27 14:10       ` Paolo Bonzini
2012-11-27 13:49     ` 陳韋任 (Wei-Ren Chen)
2012-11-27 15:05       ` Paolo Bonzini
2012-11-27 16:24       ` Andreas Färber
2012-11-27 15:53 ` Avi Kivity
2012-11-27 16:02   ` Paolo Bonzini
2012-11-27 16:49   ` Markus Armbruster
2012-11-27 16:55     ` Paolo Bonzini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-27  8:36 Paolo Bonzini
2012-11-27  9:27 ` Wenchao Xia
2012-11-27  9:37   ` Paolo Bonzini
2012-11-27 12:09     ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B4F078.6040902@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).