* [Qemu-devel] [PATCH] libcacard: build vscclient from root only
@ 2012-11-28 9:26 Alon Levy
2012-11-28 10:09 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Alon Levy @ 2012-11-28 9:26 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Alon Levy <alevy@redhat.com>
---
libcacard/Makefile | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/libcacard/Makefile b/libcacard/Makefile
index 7bce286..98c971d 100644
--- a/libcacard/Makefile
+++ b/libcacard/Makefile
@@ -1,3 +1,7 @@
+ifeq ($(BUILD_DIR),)
+ BUILD_DIR=$(CURDIR)/../
+endif
+
-include ../config-host.mak
-include $(SRC_PATH)/rules.mak
-include $(SRC_PATH)/Makefile.objs
@@ -49,12 +53,12 @@ libcacard.pc: $(libcacard_srcpath)/libcacard.pc.in
.PHONY: install-libcacard
-install-libcacard: libcacard.pc libcacard.la vscclient
+install-libcacard: libcacard.pc libcacard.la ../vscclient
$(INSTALL_DIR) "$(DESTDIR)$(libdir)"
$(INSTALL_DIR) "$(DESTDIR)$(libdir)/pkgconfig"
$(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
$(INSTALL_DIR) "$(DESTDIR)$(bindir)"
- $(LIBTOOL) --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
+ $(LIBTOOL) --mode=install $(INSTALL_PROG) ../vscclient "$(DESTDIR)$(bindir)"
$(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
$(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
for inc in *.h; do \
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] libcacard: build vscclient from root only
2012-11-28 9:26 [Qemu-devel] [PATCH] libcacard: build vscclient from root only Alon Levy
@ 2012-11-28 10:09 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2012-11-28 10:09 UTC (permalink / raw)
To: Alon Levy; +Cc: qemu-devel
Il 28/11/2012 10:26, Alon Levy ha scritto:
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
> libcacard/Makefile | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 7bce286..98c971d 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -1,3 +1,7 @@
> +ifeq ($(BUILD_DIR),)
> + BUILD_DIR=$(CURDIR)/../
> +endif
> +
> -include ../config-host.mak
> -include $(SRC_PATH)/rules.mak
> -include $(SRC_PATH)/Makefile.objs
> @@ -49,12 +53,12 @@ libcacard.pc: $(libcacard_srcpath)/libcacard.pc.in
>
> .PHONY: install-libcacard
>
> -install-libcacard: libcacard.pc libcacard.la vscclient
> +install-libcacard: libcacard.pc libcacard.la ../vscclient
> $(INSTALL_DIR) "$(DESTDIR)$(libdir)"
> $(INSTALL_DIR) "$(DESTDIR)$(libdir)/pkgconfig"
> $(INSTALL_DIR) "$(DESTDIR)$(libcacard_includedir)"
> $(INSTALL_DIR) "$(DESTDIR)$(bindir)"
> - $(LIBTOOL) --mode=install $(INSTALL_PROG) vscclient "$(DESTDIR)$(bindir)"
> + $(LIBTOOL) --mode=install $(INSTALL_PROG) ../vscclient "$(DESTDIR)$(bindir)"
> $(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.la "$(DESTDIR)$(libdir)"
> $(LIBTOOL) --mode=install $(INSTALL_DATA) libcacard.pc "$(DESTDIR)$(libdir)/pkgconfig"
> for inc in *.h; do \
>
Can you instead move all the vscclient rules to libcacard/Makefile
(including building the program as libcacard/vscclient)?
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-28 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-28 9:26 [Qemu-devel] [PATCH] libcacard: build vscclient from root only Alon Levy
2012-11-28 10:09 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).