From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1.3] event notifier: Fix setup for win32
Date: Wed, 28 Nov 2012 12:40:37 +0100 [thread overview]
Message-ID: <50B5F835.4010904@redhat.com> (raw)
In-Reply-To: <20121123070815.GD22787@stefanha-thinkpad.hitronhub.home>
Il 23/11/2012 08:08, Stefan Hajnoczi ha scritto:
> On Thu, Nov 22, 2012 at 08:56:11PM +0100, Jan Kiszka wrote:
>> The event notifier state is only reset by test_and_clear. But we created
>> the windows event object with auto-reset, which subtly swallowed events.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>
>> Grr, the last place I looked at after hours of debugging...
>>
>> event_notifier-win32.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> This should be in QEMU 1.3.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Anthony, the patch is at
http://article.gmane.org/gmane.comp.emulators.qemu/181608/raw
Please apply it for -rc2.
Paolo
next prev parent reply other threads:[~2012-11-28 11:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 19:56 [Qemu-devel] [PATCH] event notifier: Fix setup for win32 Jan Kiszka
2012-11-23 7:08 ` Stefan Hajnoczi
2012-11-28 11:40 ` Paolo Bonzini [this message]
2012-11-28 21:37 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B5F835.4010904@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).