qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	gleb@redhat.com, Jan Kiszka <jan.kiszka@siemens.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 1/7] qom: apply atomic on object's refcount
Date: Wed, 28 Nov 2012 09:16:52 -0800	[thread overview]
Message-ID: <50B64704.5040606@twiddle.net> (raw)
In-Reply-To: <1353808984-22368-2-git-send-email-qemulist@gmail.com>

On 11/24/2012 06:02 PM, Liu Ping Fan wrote:
> -    obj->ref--;
>  
>      /* parent always holds a reference to its children */
> -    if (obj->ref == 0) {
> +    if (__sync_fetch_and_sub(&obj->ref, 1) == 1) {

  if (__sync_sub_and_fetch(&obj->ref, 1) == 0)


r~

  reply	other threads:[~2012-11-28 17:17 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-25  2:02 [Qemu-devel] [PATCH v7 0/7] push mmio dispatch out of big lock Liu Ping Fan
2012-11-25  2:02 ` [Qemu-devel] [PATCH v7 1/7] qom: apply atomic on object's refcount Liu Ping Fan
2012-11-28 17:16   ` Richard Henderson [this message]
2012-11-29  8:35     ` liu ping fan
2012-11-25  2:02 ` [Qemu-devel] [PATCH v7 2/7] hotplug: introduce qdev_unplug_complete() to remove device from views Liu Ping Fan
2012-11-25  2:03 ` [Qemu-devel] [PATCH v7 3/7] pci: remove pci device from mem view when unplug Liu Ping Fan
2012-11-25  2:03 ` [Qemu-devel] [PATCH v7 4/7] memory: introduce local lock for address space Liu Ping Fan
2012-11-25  2:03 ` [Qemu-devel] [PATCH v7 5/7] memory: make mmio dispatch able to be out of biglock Liu Ping Fan
2013-05-06 11:21   ` Paolo Bonzini
2013-05-06 11:25     ` Jan Kiszka
2013-05-06 11:30       ` Paolo Bonzini
2012-11-25  2:03 ` [Qemu-devel] [PATCH v7 6/7] memory: introduce tls context to trace nested mmio request issue Liu Ping Fan
2012-11-25  2:03 ` [Qemu-devel] [PATCH v7 7/7] vcpu: push mmio dispatcher out of big lock Liu Ping Fan
2012-12-06  7:28 ` [Qemu-devel] [PATCH v7 0/7] push mmio dispatch " liu ping fan
2013-05-02 16:58   ` Jan Kiszka
2013-05-02 17:14     ` Jan Kiszka
2013-05-03  7:37     ` liu ping fan
2013-05-03  8:04       ` Jan Kiszka
2013-05-04  9:47         ` Paolo Bonzini
2013-05-04 10:42           ` Jan Kiszka
2013-05-06  8:07             ` Paolo Bonzini
2013-05-06  8:40               ` Jan Kiszka
2013-05-06 10:27                 ` Paolo Bonzini
2013-05-06 10:56                   ` Jan Kiszka
2013-05-06 10:58                     ` Paolo Bonzini
2013-05-06 11:11                       ` Jan Kiszka
2013-05-06 11:28                         ` Paolo Bonzini
2013-05-06 11:39                           ` Jan Kiszka
2013-05-06 11:47                             ` Paolo Bonzini
2013-05-06 12:06                               ` Jan Kiszka
2013-05-06 13:09                                 ` Paolo Bonzini
2013-05-06 14:05                                   ` Jan Kiszka
2013-05-06 14:28                                     ` Paolo Bonzini
2013-05-06  1:46           ` liu ping fan
2013-05-06  1:57         ` liu ping fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B64704.5040606@twiddle.net \
    --to=rth@twiddle.net \
    --cc=anthony@codemonkey.ws \
    --cc=gleb@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemulist@gmail.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).