From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdzmp-0002ad-1C for qemu-devel@nongnu.org; Thu, 29 Nov 2012 03:48:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tdzml-0004NO-2L for qemu-devel@nongnu.org; Thu, 29 Nov 2012 03:47:58 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:43158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tdzmk-0004N8-SX for qemu-devel@nongnu.org; Thu, 29 Nov 2012 03:47:54 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so8371579eek.4 for ; Thu, 29 Nov 2012 00:47:53 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50B72135.6050807@redhat.com> Date: Thu, 29 Nov 2012 09:47:49 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1354092935-6508-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1354092935-6508-7-git-send-email-xiawenc@linux.vnet.ibm.com> <50B5D690.6010909@redhat.com> <50B6FFC5.1080401@linux.vnet.ibm.com> In-Reply-To: <50B6FFC5.1080401@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V12 6/7] libqblock API implement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com Il 29/11/2012 07:25, Wenchao Xia ha scritto: >> >> How can this be called with libqb_global_data.init_flag == 1? >> > OK, I will remove the if, but keep init_flag which can show > library is already initialized. Please remove it if there is no usage elsewhere. For debugging, qemu_aio_context != NULL is just as good to check for initialization. Paolo