From: Konrad Frederic <fred.konrad@greensocs.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add()
Date: Thu, 29 Nov 2012 15:07:02 +0100 [thread overview]
Message-ID: <50B76C06.8000700@greensocs.com> (raw)
In-Reply-To: <CAFEAcA-r2Q1AF4JtJEp0OVEBTbGOxLcQ=iez7S+aA=cp3zbSJA@mail.gmail.com>
On 29/11/2012 14:56, Peter Maydell wrote:
> On 29 November 2012 13:49, Anthony Liguori<aliguori@us.ibm.com> wrote:
>> We are currently checking for an exact type match. Use QOM dynamic_cast to
>> check for a compatible type instead.
> I think this only catches the case where a bus was explicitly
> specified via bus=. For the default case you also need to change
> the similar code for checking the bus type in qbus_find_recursive(),
> right?
>
> -- PMM
Right, it's working only with the "bus=" command line.
prev parent reply other threads:[~2012-11-29 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 13:49 [Qemu-devel] [PATCH] qdev: relax bus type check in qdev_device_add() Anthony Liguori
2012-11-29 13:56 ` Peter Maydell
2012-11-29 14:07 ` Konrad Frederic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B76C06.8000700@greensocs.com \
--to=fred.konrad@greensocs.com \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).