From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Te4lI-0007UM-VR
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:06:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Te4lE-0004vb-Sx
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:06:44 -0500
Received: from greensocs.com ([87.106.252.221]:42559
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1Te4lE-0004vK-Ep
	for qemu-devel@nongnu.org; Thu, 29 Nov 2012 09:06:40 -0500
Message-ID: <50B76C06.8000700@greensocs.com>
Date: Thu, 29 Nov 2012 15:07:02 +0100
From: Konrad Frederic <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1354196978-5375-1-git-send-email-aliguori@us.ibm.com>
	<CAFEAcA-r2Q1AF4JtJEp0OVEBTbGOxLcQ=iez7S+aA=cp3zbSJA@mail.gmail.com>
In-Reply-To: <CAFEAcA-r2Q1AF4JtJEp0OVEBTbGOxLcQ=iez7S+aA=cp3zbSJA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qdev: relax bus type check in
	qdev_device_add()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 29/11/2012 14:56, Peter Maydell wrote:
> On 29 November 2012 13:49, Anthony Liguori<aliguori@us.ibm.com>  wrote:
>> We are currently checking for an exact type match.  Use QOM dynamic_cast to
>> check for a compatible type instead.
> I think this only catches the case where a bus was explicitly
> specified via bus=. For the default case you also need to change
> the similar code for checking the bus type in qbus_find_recursive(),
> right?
>
> -- PMM
Right, it's working only with the "bus=" command line.