From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TeOwa-0002ly-LG
	for qemu-devel@nongnu.org; Fri, 30 Nov 2012 06:39:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TeOwV-0006cP-JP
	for qemu-devel@nongnu.org; Fri, 30 Nov 2012 06:39:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54300)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TeOwV-0006cH-C1
	for qemu-devel@nongnu.org; Fri, 30 Nov 2012 06:39:39 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAUBdbFT032659
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 30 Nov 2012 06:39:38 -0500
Message-ID: <50B89AF6.9000406@redhat.com>
Date: Fri, 30 Nov 2012 12:39:34 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1350656885-6485-1-git-send-email-lcapitulino@redhat.com>
	<20121102112550.4ee6de09@doriath.home>
	<5093CD33.8060709@redhat.com>
	<20121102114232.2b229ec3@doriath.home>
	<20121129143419.47feb550@doriath.home>
In-Reply-To: <20121129143419.47feb550@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/6] block: bdrv_img_create(): propagate
 errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

Am 29.11.2012 17:34, schrieb Luiz Capitulino:
> On Fri, 2 Nov 2012 11:42:32 -0200
> Luiz Capitulino <lcapitulino@redhat.com> wrote:
> 
>> On Fri, 02 Nov 2012 14:40:03 +0100
>> Kevin Wolf <kwolf@redhat.com> wrote:
>>
>>> Am 02.11.2012 14:25, schrieb Luiz Capitulino:
>>>> On Fri, 19 Oct 2012 11:27:59 -0300
>>>> Luiz Capitulino <lcapitulino@redhat.com> wrote:
>>>>
>>>>> By adding error propagation to bdrv_img_create() we improve error reporting
>>>>> in qmp_transaction() and simplify qemu-img.c:img_create() a bit.
>>>>>
>>>>> Please, check individual patches for details.
>>>>
>>>> Kevin, is this in your review queue?
>>>
>>> Yes, it is. With KVM Forum and lots of other patch series, no promises
>>> though.
>>
>> Sure, just wanted to know if you were aware about it.
> 
> Still in your queue? :)

Patches look good in principle, but the bdrv_img_create() calls in
qmp_drive_mirror() aren't covered yet. Please do a quick respin for these.

Kevin