From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: spice-devel@lists.freedesktop.org, alevy@redhat.com,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev
Date: Fri, 30 Nov 2012 14:58:44 +0100 [thread overview]
Message-ID: <50B8BB94.8070302@redhat.com> (raw)
In-Reply-To: <1354281947-20227-1-git-send-email-marcandre.lureau@redhat.com>
Hi,
> This allows the Spice client to have a special port for the qemu
> monitor:
>
> ... -chardev spiceport,name=org.qemu.monitor,id=monitorport
> -mon chardev=monitorport
Nice. I think we should have a registry of names, at least for the
org.qemu.* namespace. A simple text file in docs/ should do. Monitor
needs to specify the protocol (hmp vs qmp). Also adding a number
doesn't hurt. So ...
org.qemu.monitor.hmp.0
org.qemu.monitor.qmp.0
Also nice to have:
org.qemu.console.serial.0
... and spice client redirecting that to a vte. You might have to add
some termios control messages to spiceport, so one can turn on/off echo,
send breaks, xon/xoff flow control, etc to make it work really nicely.
> Or to allow arbitrary communication outside of qemu:
>
> ... -chardev spiceport,name=org.ovirt.controller,id=...,chardev=ovcsocket
> -chardev socket,server,host=0.0.0.0,port=4242,id=ovcsocket,nowait
Hmm, so that will make qemu just hook those chardevs back-to-back and
forward data without looking at it? I'm not sure we want that ...
What is the use case? Any reason why the spice client can not (or
should not) speak to ovirt directly?
cheers,
Gerd
next prev parent reply other threads:[~2012-11-30 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 13:25 [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev Marc-André Lureau
2012-11-30 13:25 ` [Qemu-devel] [PATCH 1/6] qemu-char: add qemu_chr_remove_clients() Marc-André Lureau
2012-11-30 13:25 ` [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read Marc-André Lureau
2012-12-02 10:00 ` Alon Levy
2012-11-30 13:25 ` [Qemu-devel] [PATCH 3/6] spice-qemu-char: factor out CharDriverState creation Marc-André Lureau
2012-11-30 13:25 ` [Qemu-devel] [PATCH 4/6] spice-qemu-char: add spiceport chardev Marc-André Lureau
2012-11-30 13:25 ` [Qemu-devel] [PATCH 5/6] spice-qemu-char: keep a list of spice chardev Marc-André Lureau
2012-11-30 13:25 ` [Qemu-devel] [PATCH 6/6] spice-qemu-char: register spicevmc ports during qemu_spice_init() Marc-André Lureau
2012-11-30 13:58 ` Gerd Hoffmann [this message]
2012-11-30 14:42 ` [Qemu-devel] [PATCH 0/6] RFC: add "spiceport" chardev Marc-André Lureau
2012-11-30 15:51 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8BB94.8070302@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).