qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Mike Lovell <mike@dev-zero.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper
Date: Fri, 30 Nov 2012 15:32:08 +0100	[thread overview]
Message-ID: <50B8C368.6010500@redhat.com> (raw)
In-Reply-To: <50B88437.2080204@msgid.tls.msk.ru>

Il 30/11/2012 11:02, Michael Tokarev ha scritto:
>> I do like the idea of using a common prefix for the default name
>> of tap devices. Something like "qvif%d" instead of "tap%d" in tap
>> initialization code. But something tells me this could break
>> compatibility with external management software where something
>> might be expecting the interface name to start with tap.
>
> Does any management interface use this bridge-helper functionality? 

Libvirt uses it if you're running libvirtd without privileges.  GNOME
Boxes is a 1-line patch away from using it, but it's Fedora-specific and
not included in any distro.

Paolo

> If it were me, I'd always created the tap fd in the management layer
> and passed the tap fd# (or at least ifname= of an existing iface) to
> qemu.  Bridge helper is useful for users calling qemu directly, not
> for management software.  Sure, such users are also important -
> including compatibility.  But I don't think current unpredictable
> tapNN names was a good idea to start with, and that it's good idea to
> rely on this prefix in firewall rules or whatnot.

  reply	other threads:[~2012-11-30 14:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10 15:05 [Qemu-devel] [feature request] qemu-bridge-helper Mario De Chenno
2012-10-11 15:31 ` Corey Bryant
2012-10-12  6:49   ` [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper Mike Lovell
2012-10-12  7:03     ` Mike Lovell
2012-10-12  8:32     ` Michael Tokarev
2012-10-12 18:04       ` Mike Lovell
2012-11-30 10:02         ` Michael Tokarev
2012-11-30 14:32           ` Paolo Bonzini [this message]
2012-11-30  7:10     ` Mike Lovell
2012-11-30 14:35       ` Paolo Bonzini
2012-12-03 13:10         ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B8C368.6010500@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=mike@dev-zero.net \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).