From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeRdg-0001oE-55 for qemu-devel@nongnu.org; Fri, 30 Nov 2012 09:32:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TeRda-0003iZ-CU for qemu-devel@nongnu.org; Fri, 30 Nov 2012 09:32:24 -0500 Received: from mail-pb0-f45.google.com ([209.85.160.45]:42872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeRda-0003iR-5w for qemu-devel@nongnu.org; Fri, 30 Nov 2012 09:32:18 -0500 Received: by mail-pb0-f45.google.com with SMTP id mc8so452356pbc.4 for ; Fri, 30 Nov 2012 06:32:16 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50B8C368.6010500@redhat.com> Date: Fri, 30 Nov 2012 15:32:08 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <5076E640.4090003@linux.vnet.ibm.com> <1350024543-26211-1-git-send-email-mike@dev-zero.net> <5077D584.3040204@msgid.tls.msk.ru> <50785B9F.50609@dev-zero.net> <50B88437.2080204@msgid.tls.msk.ru> In-Reply-To: <50B88437.2080204@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Mike Lovell , qemu-devel@nongnu.org Il 30/11/2012 11:02, Michael Tokarev ha scritto: >> I do like the idea of using a common prefix for the default name >> of tap devices. Something like "qvif%d" instead of "tap%d" in tap >> initialization code. But something tells me this could break >> compatibility with external management software where something >> might be expecting the interface name to start with tap. > > Does any management interface use this bridge-helper functionality? Libvirt uses it if you're running libvirtd without privileges. GNOME Boxes is a 1-line patch away from using it, but it's Fedora-specific and not included in any distro. Paolo > If it were me, I'd always created the tap fd in the management layer > and passed the tap fd# (or at least ifname= of an existing iface) to > qemu. Bridge helper is useful for users calling qemu directly, not > for management software. Sure, such users are also important - > including compatibility. But I don't think current unpredictable > tapNN names was a good idea to start with, and that it's good idea to > rely on this prefix in firewall rules or whatnot.