From: Paolo Bonzini <pbonzini@redhat.com>
To: Mike Lovell <mike@dev-zero.net>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper
Date: Fri, 30 Nov 2012 15:35:46 +0100 [thread overview]
Message-ID: <50B8C442.70007@redhat.com> (raw)
In-Reply-To: <50B85BEA.6000107@dev-zero.net>
Il 30/11/2012 08:10, Mike Lovell ha scritto:
> On 10/12/2012 12:49 AM, Mike Lovell wrote:
>> This makes a few changes to allow ifname to be specified when using
>> qemu-bridge-helper with both the bridge and tap network interfaces. It
>> adds
>> the --ifname option to qemu-bridge-helper, removes the restriction
>> that ifname
>> cannot be specified with helper for the tap interface, and adds logic to
>> specify the --ifname option when exec'ing the helper.
>
> ping ... or syn. any other thoughts about this?
I share Michael's perplexity. This feature could be exploitable.
If we want to add this, the ifname should be subject to ACL rules just
like bridge names. For example you could have a special allow/deny
directive "allow foo@" which allows ifnames starting with "foo".
Paolo
next prev parent reply other threads:[~2012-11-30 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:05 [Qemu-devel] [feature request] qemu-bridge-helper Mario De Chenno
2012-10-11 15:31 ` Corey Bryant
2012-10-12 6:49 ` [Qemu-devel] [PATCH] net: Allow specifying ifname for qemu-bridge-helper Mike Lovell
2012-10-12 7:03 ` Mike Lovell
2012-10-12 8:32 ` Michael Tokarev
2012-10-12 18:04 ` Mike Lovell
2012-11-30 10:02 ` Michael Tokarev
2012-11-30 14:32 ` Paolo Bonzini
2012-11-30 7:10 ` Mike Lovell
2012-11-30 14:35 ` Paolo Bonzini [this message]
2012-12-03 13:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B8C442.70007@redhat.com \
--to=pbonzini@redhat.com \
--cc=mike@dev-zero.net \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).