From: Igor Mitsyanko <i.mitsyanko@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
Mark Langsdorf <mark.langsdorf@calxeda.com>,
Evgeny Voevodin <e.voevodin@samsung.com>,
patches@linaro.org, Marc Zyngier <marc.zyngier@arm.com>,
qemu-devel@nongnu.org, Dmitry Solodkiy <d.solodkiy@samsung.com>,
Maksim Kozlov <m.kozlov@samsung.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/arm_gic: Fix comparison with priority mask register
Date: Sun, 02 Dec 2012 01:27:39 +0400 [thread overview]
Message-ID: <50BA764B.5090306@gmail.com> (raw)
In-Reply-To: <1354208577-8935-3-git-send-email-peter.maydell@linaro.org>
On 11/29/2012 9:02 PM, Peter Maydell wrote:
> The GIC spec states that only interrupts with higher priority
> than the value in the GICC_PMR priority mask register are
> passed through to the processor. We were incorrectly allowing
> through interrupts with a priority equal to the specified
> value: correct the comparison operation to match the spec.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/arm_gic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm_gic.c b/hw/arm_gic.c
> index f9e423f..672d539 100644
> --- a/hw/arm_gic.c
> +++ b/hw/arm_gic.c
> @@ -73,7 +73,7 @@ void gic_update(GICState *s)
> }
> }
> level = 0;
> - if (best_prio <= s->priority_mask[cpu]) {
> + if (best_prio < s->priority_mask[cpu]) {
> s->current_pending[cpu] = best_irq;
> if (best_prio < s->running_priority[cpu]) {
> DPRINTF("Raised pending IRQ %d\n", best_irq);
>
Reviewed-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
next prev parent reply other threads:[~2012-12-01 21:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 17:02 [Qemu-devel] [PATCH 0/3] ARM: fix secondary boot GIC init, GIC bugs Peter Maydell
2012-11-29 17:02 ` [Qemu-devel] [PATCH 1/3] hw/arm_boot, exynos4210, highbank: Fix secondary boot GIC init Peter Maydell
2012-12-01 21:27 ` Igor Mitsyanko
2012-11-29 17:02 ` [Qemu-devel] [PATCH 2/3] hw/arm_gic: Fix comparison with priority mask register Peter Maydell
2012-12-01 15:50 ` [Qemu-devel] [kvmarm] " Christoffer Dall
2012-12-01 21:27 ` Igor Mitsyanko [this message]
2012-11-29 17:02 ` [Qemu-devel] [PATCH 3/3] hw/arm_gic_common: Correct GICC_PMR reset value for newer GICs Peter Maydell
2012-12-01 21:27 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BA764B.5090306@gmail.com \
--to=i.mitsyanko@gmail.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=m.kozlov@samsung.com \
--cc=marc.zyngier@arm.com \
--cc=mark.langsdorf@calxeda.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).