From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tf1bg-0002iG-CB for qemu-devel@nongnu.org; Sat, 01 Dec 2012 23:56:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tf1bf-0007Ew-Bi for qemu-devel@nongnu.org; Sat, 01 Dec 2012 23:56:44 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39471 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tf1bf-0007Es-5N for qemu-devel@nongnu.org; Sat, 01 Dec 2012 23:56:43 -0500 Message-ID: <50BADF85.7060805@suse.de> Date: Sun, 02 Dec 2012 05:56:37 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1354423851-24818-1-git-send-email-afaerber@suse.de> <1354423851-24818-2-git-send-email-afaerber@suse.de> In-Reply-To: <1354423851-24818-2-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 01/11] cpu: Move kvm_fd into CPUState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: anthony@codemonkey.ws, mtosatti@redhat.com, Avi Kivity , kvm@vger.kernel.org Am 02.12.2012 05:50, schrieb Andreas F=C3=A4rber: > diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h > index 61b7698..6c66fc0 100644 > --- a/include/qemu/cpu.h > +++ b/include/qemu/cpu.h > @@ -77,6 +77,10 @@ struct CPUState { > bool stop; > bool stopped; > =20 > +#if !defined(CONFIG_USER_ONLY) > + int kvm_fd; > +#endif > + > /* TODO Move common fields from CPUArchState here. */ > }; > =20 First nit found myself: I strive to set good examples, so this field addition should've been accompanied by a documentation update. ;) I'll defer a v2 until other people have had a chance to review though. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg