From: "Andreas Färber" <afaerber@suse.de>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: "blauwirbel@gmail.com" <blauwirbel@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"ehabkost@redhat.com" <ehabkost@redhat.com>,
"imammedo@redhat.com" <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function
Date: Mon, 03 Dec 2012 12:19:54 +0100 [thread overview]
Message-ID: <50BC8ADA.4010201@suse.de> (raw)
In-Reply-To: <50BC7429.3060907@siemens.com>
Am 03.12.2012 10:43, schrieb Jan Kiszka:
> On 2012-12-03 04:07, liguang wrote:
>> 1. define names of breakpoints in dr7
>> 2. slightly refactor bits field of breakpoint
>> related functions.
>
> Two topics, (at least) two patches, please. The code is hairy - not your
> fault, you actually try to improve it. But splitting up makes review
> easier. Thanks in advance.
I was going to request the same thing: Please first introduce the new
constants, then do functional changes on top.
When you do that, please remember to include a short cover letter and
use git-send-email so that the patches stay together. :)
The following link may be helpful for avoiding coding style issues:
http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-03 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 3:07 [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function liguang
2012-12-03 9:43 ` Jan Kiszka
2012-12-03 11:19 ` Andreas Färber [this message]
2012-12-04 0:46 ` li guang
2012-12-04 0:45 ` li guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BC8ADA.4010201@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).