From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfU4r-0005Ec-MT
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 06:20:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfU4l-0005re-Mg
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 06:20:45 -0500
Received: from cantor2.suse.de ([195.135.220.15]:52583 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfU4l-0005VN-G0
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 06:20:39 -0500
Message-ID: <50BC8ADA.4010201@suse.de>
Date: Mon, 03 Dec 2012 12:19:54 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1354504047-11615-1-git-send-email-lig.fnst@cn.fujitsu.com>
	<50BC7429.3060907@siemens.com>
In-Reply-To: <50BC7429.3060907@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related
 function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liguang <lig.fnst@cn.fujitsu.com>
Cc: "blauwirbel@gmail.com" <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@siemens.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "ehabkost@redhat.com" <ehabkost@redhat.com>, "imammedo@redhat.com" <imammedo@redhat.com>

Am 03.12.2012 10:43, schrieb Jan Kiszka:
> On 2012-12-03 04:07, liguang wrote:
>> 1. define names of breakpoints in dr7
>> 2. slightly refactor bits field of breakpoint
>>    related functions.
>=20
> Two topics, (at least) two patches, please. The code is hairy - not you=
r
> fault, you actually try to improve it. But splitting up makes review
> easier. Thanks in advance.

I was going to request the same thing: Please first introduce the new
constants, then do functional changes on top.

When you do that, please remember to include a short cover letter and
use git-send-email so that the patches stay together. :)

The following link may be helpful for avoiding coding style issues:
http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.ht=
ml

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg