From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36094)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1TfZ1N-0008As-8v
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 11:37:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1TfZ1J-0004gD-5P
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 11:37:29 -0500
Received: from smtp02.citrix.com ([66.165.176.63]:46322)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien.grall@citrix.com>) id 1TfZ1J-0004cK-0J
	for qemu-devel@nongnu.org; Mon, 03 Dec 2012 11:37:25 -0500
Message-ID: <50BCD366.9060705@citrix.com>
Date: Mon, 3 Dec 2012 16:29:26 +0000
From: Julien Grall <julien.grall@citrix.com>
MIME-Version: 1.0
References: <cover.1348052498.git.julien.grall@citrix.com>
	<0bc7997d87e325be985811d2627c339f7fc2b961.1348052498.git.julien.grall@citrix.com>
	<50B404E8.6070102@suse.de> <20121127204604.GE2425@redhat.com>
In-Reply-To: <20121127204604.GE2425@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Baron <jbaron@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "jan.kiszka@siemens.com" <jan.kiszka@siemens.com>, "kraxel@redhat.com" <kraxel@redhat.com>, "avi@redhat.com" <avi@redhat.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>

On 11/27/2012 08:46 PM, Jason Baron wrote:

> On Tue, Nov 27, 2012 at 01:10:16AM +0100, Andreas Färber wrote:
>> Am 19.09.2012 13:50, schrieb Julien Grall:
>>> This patch replaces all register_ioport* by a MemorySection.
>>> It permits to use the new Memory stuff like listener.
>>>
>>> Moreover, the PCI is added as an argument for apm_init, so we
>>> can register IO inside the pci IO address space.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@citrix.com>
>>
>> Following today's q35 merge I needed the following diff to fix the build:
>>
>> diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c
>> index 2fc83a4..7de5427 100644
>> --- a/hw/lpc_ich9.c
>> +++ b/hw/lpc_ich9.c
>> @@ -472,7 +472,7 @@ static int ich9_lpc_initfn(PCIDevice *d)
>>      lpc->isa_bus = isa_bus;
>>
>>      ich9_cc_init(lpc);
>> -    apm_init(&lpc->apm, ich9_apm_ctrl_changed, lpc);
>> +    apm_init(d, &lpc->apm, ich9_apm_ctrl_changed, lpc);
>>      return 0;
>>  }
>>
>> Julien/Jason, can you please verify that this is the correct device to pass?
>>
> 
> Looks correct to me.

It's ok for me.

Thanks,

Julien