From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfjCg-0004mS-F0 for qemu-devel@nongnu.org; Mon, 03 Dec 2012 22:29:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfjCc-0007wn-9w for qemu-devel@nongnu.org; Mon, 03 Dec 2012 22:29:50 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:50344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfjCb-0007vb-O0 for qemu-devel@nongnu.org; Mon, 03 Dec 2012 22:29:46 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Dec 2012 08:59:33 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 91ABE125804B for ; Tue, 4 Dec 2012 08:59:23 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qB43Tc3Z38797510 for ; Tue, 4 Dec 2012 08:59:38 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qB43Td2b020960 for ; Tue, 4 Dec 2012 14:29:39 +1100 Message-ID: <50BD6DF4.6010700@linux.vnet.ibm.com> Date: Tue, 04 Dec 2012 11:28:52 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1354187535-16803-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1354187535-16803-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Build system clean generated source files in tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com Resent for that 1.3 have been released. I think this problem should be fixed otherwise out of tree build fails strangely. > Currently .c files generated in ./tests are not deleted in make > clean. This introduce trouble that, once we made tests in source > root directory, we can't do a succesfully build for tests in another > out of tree directory, for that some file may miss the step to be > generated. This patch fix it. > > Steps to reproduce: > in root source directory: > 1 ./configure --target-list=x86_64-softmmu > 2 make check-report-unit.xml > 3 make distclean && rm -rf *-linux-user *-softmmu > goto another directory: > 4 configure > 5 make check-report-unit.xml > > Signed-off-by: Wenchao Xia > --- > tests/Makefile | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/tests/Makefile b/tests/Makefile > index b60f0fb..2c90138 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -30,6 +30,7 @@ check-qtest-sparc-y = tests/m48t59-test$(EXESUF) > check-qtest-sparc64-y = tests/m48t59-test$(EXESUF) > > GENERATED_HEADERS += tests/test-qapi-types.h tests/test-qapi-visit.h tests/test-qmp-commands.h > +GENERATED_SOURCES += tests/test-qapi-types.c tests/test-qapi-visit.c tests/test-qmp-marshal.c > > test-obj-y = tests/check-qint.o tests/check-qstring.o tests/check-qdict.o \ > tests/check-qlist.o tests/check-qfloat.o tests/check-qjson.o \ > -- Best Regards Wenchao Xia