* [Qemu-devel] [PATCH for-1.3] Build system clean generated source files in tests
@ 2012-11-29 11:12 Wenchao Xia
2012-12-04 3:28 ` [Qemu-devel] [PATCH] " Wenchao Xia
0 siblings, 1 reply; 3+ messages in thread
From: Wenchao Xia @ 2012-11-29 11:12 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, aliguori, stefanha, blauwirbel, pbonzini, Wenchao Xia
Currently .c files generated in ./tests are not deleted in make
clean. This introduce trouble that, once we made tests in source
root directory, we can't do a succesfully build for tests in another
out of tree directory, for that some file may miss the step to be
generated. This patch fix it.
Steps to reproduce:
in root source directory:
1 ./configure --target-list=x86_64-softmmu
2 make check-report-unit.xml
3 make distclean && rm -rf *-linux-user *-softmmu
goto another directory:
4 configure
5 make check-report-unit.xml
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
tests/Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tests/Makefile b/tests/Makefile
index b60f0fb..2c90138 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -30,6 +30,7 @@ check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
GENERATED_HEADERS += tests/test-qapi-types.h tests/test-qapi-visit.h tests/test-qmp-commands.h
+GENERATED_SOURCES += tests/test-qapi-types.c tests/test-qapi-visit.c tests/test-qmp-marshal.c
test-obj-y = tests/check-qint.o tests/check-qstring.o tests/check-qdict.o \
tests/check-qlist.o tests/check-qfloat.o tests/check-qjson.o \
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Build system clean generated source files in tests
2012-11-29 11:12 [Qemu-devel] [PATCH for-1.3] Build system clean generated source files in tests Wenchao Xia
@ 2012-12-04 3:28 ` Wenchao Xia
0 siblings, 0 replies; 3+ messages in thread
From: Wenchao Xia @ 2012-12-04 3:28 UTC (permalink / raw)
To: Wenchao Xia; +Cc: kwolf, aliguori, stefanha, qemu-devel, blauwirbel, pbonzini
Resent for that 1.3 have been released. I think this problem should
be fixed otherwise out of tree build fails strangely.
> Currently .c files generated in ./tests are not deleted in make
> clean. This introduce trouble that, once we made tests in source
> root directory, we can't do a succesfully build for tests in another
> out of tree directory, for that some file may miss the step to be
> generated. This patch fix it.
>
> Steps to reproduce:
> in root source directory:
> 1 ./configure --target-list=x86_64-softmmu
> 2 make check-report-unit.xml
> 3 make distclean && rm -rf *-linux-user *-softmmu
> goto another directory:
> 4 configure
> 5 make check-report-unit.xml
>
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
> tests/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index b60f0fb..2c90138 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -30,6 +30,7 @@ check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
> check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
>
> GENERATED_HEADERS += tests/test-qapi-types.h tests/test-qapi-visit.h tests/test-qmp-commands.h
> +GENERATED_SOURCES += tests/test-qapi-types.c tests/test-qapi-visit.c tests/test-qmp-marshal.c
>
> test-obj-y = tests/check-qint.o tests/check-qstring.o tests/check-qdict.o \
> tests/check-qlist.o tests/check-qfloat.o tests/check-qjson.o \
>
--
Best Regards
Wenchao Xia
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] Build system clean generated source files in tests
@ 2012-12-09 4:48 Wenchao Xia
0 siblings, 0 replies; 3+ messages in thread
From: Wenchao Xia @ 2012-12-09 4:48 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, aliguori, stefanha, blauwirbel, pbonzini, Wenchao Xia
Currently .c files generated in ./tests are not deleted in make
clean. This introduce trouble that, once we made tests in source
root directory, we can't do a succesfully build for tests in another
out of tree directory, for that some file may miss the step to be
generated. This patch fix it.
Steps to reproduce:
in root source directory:
1 ./configure --target-list=x86_64-softmmu
2 make check-report-unit.xml
3 make distclean && rm -rf *-linux-user *-softmmu
goto another directory:
4 configure
5 make check-report-unit.xml
v2:
rebased to upstream
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
tests/Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tests/Makefile b/tests/Makefile
index b60f0fb..2c90138 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -30,6 +30,7 @@ check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
GENERATED_HEADERS += tests/test-qapi-types.h tests/test-qapi-visit.h tests/test-qmp-commands.h
+GENERATED_SOURCES += tests/test-qapi-types.c tests/test-qapi-visit.c tests/test-qmp-marshal.c
test-obj-y = tests/check-qint.o tests/check-qstring.o tests/check-qdict.o \
tests/check-qlist.o tests/check-qfloat.o tests/check-qjson.o \
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-09 4:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-29 11:12 [Qemu-devel] [PATCH for-1.3] Build system clean generated source files in tests Wenchao Xia
2012-12-04 3:28 ` [Qemu-devel] [PATCH] " Wenchao Xia
-- strict thread matches above, loose matches on Subject: below --
2012-12-09 4:48 Wenchao Xia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).