From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfuyL-0001XR-7T
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:03:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfuyB-0001sf-Mr
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:03:49 -0500
Received: from cantor2.suse.de ([195.135.220.15]:59696 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TfuyB-0001sZ-Dn
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:03:39 -0500
Message-ID: <50BE1ED8.5030509@suse.de>
Date: Tue, 04 Dec 2012 17:03:36 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1354627180-25704-1-git-send-email-ehabkost@redhat.com>
	<1354627180-25704-2-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1354627180-25704-2-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 1/8] move -I$(SRC_PATH)/include compiler flag
	to Makefile.objs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

Am 04.12.2012 14:19, schrieb Eduardo Habkost:
> The flag is necessary for code that doesn't use the variables from
> Makefile (but use Makefile.objs), like libcacard/ and stubs/.
>=20
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

I don't quite understand the rationale of this patch.
libcacard/ and stubs/ shouldn't need vl.o, do they? The CFLAGS move
makes more sense to me.

Paolo, can you take a look please?

Thanks,
Andreas

> ---
>  Makefile      |  1 -
>  Makefile.objs | 15 +++++++++------
>  2 files changed, 9 insertions(+), 7 deletions(-)
>=20
> diff --git a/Makefile b/Makefile
> index 9ecbcbb..739d9cd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -145,7 +145,6 @@ audio/audio.o audio/fmodaudio.o: QEMU_CFLAGS +=3D $=
(FMOD_CFLAGS)
> =20
>  QEMU_CFLAGS+=3D$(CURL_CFLAGS)
> =20
> -QEMU_CFLAGS +=3D -I$(SRC_PATH)/include
> =20
>  ui/cocoa.o: ui/cocoa.m
> =20
> diff --git a/Makefile.objs b/Makefile.objs
> index 3c7abca..0a0a33a 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -1,4 +1,13 @@
>  ######################################################################=
#
> +# general compiler flags
> +
> +QEMU_CFLAGS +=3D $(GLIB_CFLAGS)
> +QEMU_CFLAGS +=3D -I$(SRC_PATH)/include
> +
> +vl.o: QEMU_CFLAGS+=3D$(GPROF_CFLAGS)
> +vl.o: QEMU_CFLAGS+=3D$(SDL_CFLAGS)
> +
> +######################################################################=
#
>  # Stub library, linked in tools
>  stub-obj-y =3D stubs/
> =20
> @@ -236,12 +245,6 @@ universal-obj-y +=3D $(qapi-obj-y)
>  qga-obj-y =3D qga/ qemu-ga.o module.o qemu-tool.o
>  qga-obj-$(CONFIG_POSIX) +=3D qemu-sockets.o qemu-option.o
> =20
> -vl.o: QEMU_CFLAGS+=3D$(GPROF_CFLAGS)
> -
> -vl.o: QEMU_CFLAGS+=3D$(SDL_CFLAGS)
> -
> -QEMU_CFLAGS+=3D$(GLIB_CFLAGS)
> -
>  nested-vars +=3D \
>  	stub-obj-y \
>  	qga-obj-y \

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg