From: Gerd Hoffmann <kraxel@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api
Date: Tue, 04 Dec 2012 17:05:17 +0100 [thread overview]
Message-ID: <50BE1F3D.1060302@redhat.com> (raw)
In-Reply-To: <50BE1D52.2070703@suse.de>
On 12/04/12 16:57, Andreas Färber wrote:
> Hi Gerd,
>
> Am 04.12.2012 14:04, schrieb Gerd Hoffmann:
>> Hi,
>>
>> Same patches as posted last week. No review comments, 1.4 tree
>> open, so it should be ready to go in now.
>
> That's not quite true - you ignored my review comment wrt MemoryRegion
> placement (and I left it to you to look for further instances). Can you
> please fix that up on your branch or as follow-up?
You mean that empty line after parent_object? I can send a followup for
that one.
Why it is important btw? Just style? Some parser tool? Can we make
checkpatch.pl check this?
> Did you see any overlap with Julien's series or can I post my PULL in
> parallel?
Given that you kicked out the acpi changes due to q35 merge conflicts it
should work in parallel as my series touches acpi only. Havn't actually
tried to merge though.
A small followup is needed once both are in: replace get_system_io()
with the new isa_address_space() in the acpi code.
cheers,
Gerd
next prev parent reply other threads:[~2012-12-04 16:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 13:04 [Qemu-devel] [PULL 00/18] acpi: switch to memory api Gerd Hoffmann
2012-12-04 13:04 ` [Qemu-devel] [PATCH 01/18] apci: switch piix4 " Gerd Hoffmann
2012-12-04 13:04 ` [Qemu-devel] [PATCH 02/18] apci: switch ich9 " Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 03/18] apci: switch vt82c686 " Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 04/18] apci: switch timer " Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 05/18] apci: switch cnt " Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 06/18] apci: switch evt " Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 07/18] acpi: cleanup piix4 memory region Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 08/18] acpi: cleanup vt82c686 " Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 09/18] apci: switch ich9 gpe to memory api Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 10/18] apci: switch ich9 smi " Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 11/18] acpi: cleanup ich9 memory region Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 12/18] acpi: switch smbus to memory api Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 13/18] acpi: fix piix4 smbus mapping Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 14/18] apci: switch piix4 gpe to memory api Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 15/18] acpi: remove acpi_gpe_blk Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 16/18] apci: switch piix4 pci hotplug to memory api Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 17/18] q35: update lpc pci config space according to configured devices Gerd Hoffmann
2012-12-04 13:05 ` [Qemu-devel] [PATCH 18/18] acpi: drop debug port Gerd Hoffmann
2012-12-04 15:57 ` [Qemu-devel] [PULL 00/18] acpi: switch to memory api Andreas Färber
2012-12-04 16:05 ` Gerd Hoffmann [this message]
2012-12-05 16:49 ` Andreas Färber
2012-12-10 16:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BE1F3D.1060302@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).