From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfv02-0002nI-MN for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:05:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tfuzt-0002WV-7V for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:05:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfuzs-0002WL-VQ for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:05:25 -0500 Message-ID: <50BE1F3D.1060302@redhat.com> Date: Tue, 04 Dec 2012 17:05:17 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1354626315-31186-1-git-send-email-kraxel@redhat.com> <50BE1D52.2070703@suse.de> In-Reply-To: <50BE1D52.2070703@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org On 12/04/12 16:57, Andreas F=E4rber wrote: > Hi Gerd, >=20 > Am 04.12.2012 14:04, schrieb Gerd Hoffmann: >> Hi, >> >> Same patches as posted last week. No review comments, 1.4 tree >> open, so it should be ready to go in now. >=20 > That's not quite true - you ignored my review comment wrt MemoryRegion > placement (and I left it to you to look for further instances). Can you > please fix that up on your branch or as follow-up? You mean that empty line after parent_object? I can send a followup for that one. Why it is important btw? Just style? Some parser tool? Can we make checkpatch.pl check this? > Did you see any overlap with Julien's series or can I post my PULL in > parallel? Given that you kicked out the acpi changes due to q35 merge conflicts it should work in parallel as my series touches acpi only. Havn't actually tried to merge though. A small followup is needed once both are in: replace get_system_io() with the new isa_address_space() in the acpi code. cheers, Gerd