From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfvqV-0002yA-UR for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:59:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TfvqQ-0000Kn-6u for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:59:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TfvqP-0000Kh-VW for qemu-devel@nongnu.org; Tue, 04 Dec 2012 11:59:42 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB4Gxf0M014059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Dec 2012 11:59:41 -0500 Message-ID: <50BE2BFA.4020602@redhat.com> Date: Tue, 04 Dec 2012 17:59:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1354633939-29940-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1354633939-29940-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] tests: avoid aio_flush() in test cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org Il 04/12/2012 16:12, Stefan Hajnoczi ha scritto: > There is a patch to drop aio_flush(). Most callers shouldn't use that > interface. It turns out that the aio and thread pool test cases *do* need > low-level flush functionality so they can test the aio code. > > Convert test-aio.c and test-thread-pool.c to use replacements for > qemu_aio_flush() and aio_flush(). > > Stefan Hajnoczi (2): > tests: use aio_poll() instead of aio_flush() in test-aio.c > tests: avoid qemu_aio_flush() in test-thread-pool.c > > tests/test-aio.c | 31 +++++++++++++++---------------- > tests/test-thread-pool.c | 20 ++++++++++++++------ > 2 files changed, 29 insertions(+), 22 deletions(-) > Looks good. Paolo