From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Antoine Mathys <barsamin@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS register.
Date: Tue, 04 Dec 2012 19:53:35 +0100 [thread overview]
Message-ID: <50BE46AF.1030001@suse.de> (raw)
In-Reply-To: <CAFEAcA_2jUmHLgEBYgi368MZx3-WsowJNm8WCEy5KuC++bYy-Q@mail.gmail.com>
Am 04.12.2012 18:42, schrieb Peter Maydell:
> On 2 December 2012 17:14, Antoine Mathys <barsamin@gmail.com> wrote:
>> Per the datasheet, the mapping between 12 and 24 hours modes is:
>> 0 <-> 12 PM
>> 1-12 <-> 1-12 AM
>> 13-23 <-> 1-11 PM
>>
>> Signed-off-by: Antoine Mathys <barsamin@gmail.com>
>
> This looks good as far as the logic goes, but I think we
> could use some symbolic constants for the 12-hour and PM
> bits rather than all the literal 0x20 0x40 0x60.
What about adding qtests like we have for the x86 RTC?
Is I2C as problematic as PCI there?
Andreas
P.S. Antoine, please make sure you thread your patches to a cover letter
so that they stay together on the list.
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-12-04 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 17:14 [Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS register Antoine Mathys
2012-12-04 17:42 ` Peter Maydell
2012-12-04 18:53 ` Andreas Färber [this message]
2012-12-04 20:57 ` Antoine Mathys
2012-12-04 21:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BE46AF.1030001@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=barsamin@gmail.com \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).