From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tfxcj-0003SY-0c
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 13:53:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tfxch-0004TN-RL
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 13:53:40 -0500
Received: from cantor2.suse.de ([195.135.220.15]:37798 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tfxch-0004TD-Kf
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 13:53:39 -0500
Message-ID: <50BE46AF.1030001@suse.de>
Date: Tue, 04 Dec 2012 19:53:35 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <50BB8C7A.7010304@gmail.com>
	<CAFEAcA_2jUmHLgEBYgi368MZx3-WsowJNm8WCEy5KuC++bYy-Q@mail.gmail.com>
In-Reply-To: <CAFEAcA_2jUmHLgEBYgi368MZx3-WsowJNm8WCEy5KuC++bYy-Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] hw/ds1338.c: Fix handling of HOURS
	register.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Antoine Mathys <barsamin@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, paul@codesourcery.com

Am 04.12.2012 18:42, schrieb Peter Maydell:
> On 2 December 2012 17:14, Antoine Mathys <barsamin@gmail.com> wrote:
>> Per the datasheet, the mapping between 12 and 24 hours modes is:
>>     0      <->  12   PM
>>     1-12   <->  1-12 AM
>>     13-23  <->  1-11 PM
>>
>> Signed-off-by: Antoine Mathys <barsamin@gmail.com>
>=20
> This looks good as far as the logic goes, but I think we
> could use some symbolic constants for the 12-hour and PM
> bits rather than all the literal 0x20 0x40 0x60.

What about adding qtests like we have for the x86 RTC?
Is I2C as problematic as PCI there?

Andreas

P.S. Antoine, please make sure you thread your patches to a cover letter
so that they stay together on the list.

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg