From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33448)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tfzo8-0005Bl-7s
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 16:13:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tfzo7-0007XO-7R
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 16:13:36 -0500
Received: from cantor2.suse.de ([195.135.220.15]:42136 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tfzo7-0007XI-0k
	for qemu-devel@nongnu.org; Tue, 04 Dec 2012 16:13:35 -0500
Message-ID: <50BE6778.8090404@suse.de>
Date: Tue, 04 Dec 2012 22:13:28 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1354632583-22403-1-git-send-email-petar.jovanovic@rt-rk.com>,
	<CAAu8pHuJzKVVKWBX5JcanxESvzhKjywHTc4p+qLh2Gw7yW=1=A@mail.gmail.com>
	<874D219413C17C42B1D2E0432B92BE5CBBE2890C@exchdb03.mips.com>
In-Reply-To: <874D219413C17C42B1D2E0432B92BE5CBBE2890C@exchdb03.mips.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-mips: Fix incorrect shift for SHILO
 and SHILOV
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Jovanovic, Petar" <petarj@mips.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "aurelien@aurel32.net" <aurelien@aurel32.net>

Am 04.12.2012 20:48, schrieb Jovanovic, Petar:
>> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
>> index e7949c2..f8a7a9f 100644
>> --- a/target-mips/dsp_helper.c
>> +++ b/target-mips/dsp_helper.c
>> @@ -3814,17 +3814,17 @@ void helper_shilo(target_ulong ac, target_ulon=
g rs, CPUMIPSState *env)
>>
>>      rs5_0 =3D rs & 0x3F;
>>      rs5_0 =3D (int8_t)(rs5_0 << 2) >> 2;
>> -    rs5_0 =3D MIPSDSP_ABS(rs5_0);
>> +
>> +    if (rs5_0 =3D=3D 0)
>> +        return;
>=20
>> The check should be moved to translation time so that the call to this
>> helper is not generated at all.
>=20
> This case is not likely so generation of unnecessary call is unlikely t=
oo.
> Let me know what you think.

FWIW you could use our unlikely() macro then to aid branch prediction.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg