From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TgAh2-0005y9-DC
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 03:51:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TgAh0-0005Dp-M0
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 03:51:00 -0500
Received: from david.siemens.de ([192.35.17.14]:23002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TgAh0-0005DU-Ck
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 03:50:58 -0500
Message-ID: <50BF0AE1.5010606@siemens.com>
Date: Wed, 05 Dec 2012 09:50:41 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1353815517-319-1-git-send-email-qemulist@gmail.com>
	<1353815517-319-2-git-send-email-qemulist@gmail.com>
	<CAKjmthLpv42dAAbmtG4EbHu_QQ7=Qsf0qdiDCEsY4UC9SXrSpQ@mail.gmail.com>
In-Reply-To: <CAKjmthLpv42dAAbmtG4EbHu_QQ7=Qsf0qdiDCEsY4UC9SXrSpQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt
	among VMs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: Liu Ping Fan <qemulist@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2012-12-05 06:34, Cam Macdonell wrote:
>>  static void ivshmem_write_config(PCIDevice *pci_dev, uint32_t address,
>>                                  uint32_t val, int len)
>>  {
>> +    bool is_enabled, was_enabled = msi_enabled(pci_dev);
>> +
>>      pci_default_write_config(pci_dev, address, val, len);
>> +    is_enabled = msi_enabled(pci_dev);
> 
> Problem 1)  in my tests is_enabled is always 0, so I don't think the
> irqfds are getting setup

You likely want to call msix_enabled here.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux