From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TgCsa-0002XW-L0
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:11:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TgCsU-0004qf-N4
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:11:04 -0500
Message-ID: <50BF2BBA.5010708@suse.de>
Date: Wed, 05 Dec 2012 12:10:50 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1354655711.git.blauwirbel@gmail.com>
	<ed7b40c84fd3ee1b5e64a07e3038e89eb20213d3.1354655711.git.blauwirbel@gmail.com>
In-Reply-To: <ed7b40c84fd3ee1b5e64a07e3038e89eb20213d3.1354655711.git.blauwirbel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/4] exec: refactor cpu_restore_state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, qemu-ppc@nongnu.org, Paul Brook <paul@codesourcery.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

Am 04.12.2012 22:20, schrieb Blue Swirl:
> Refactor common code around calls to cpu_restore_state().
>=20
> tb_find_pc() has now no external users, make it static.
>=20
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>

Would've been nice to get CC'ed on the refactoring of a cpu_* function...

I've reviewed mostly the non-target parts and they look okay,
CPUArchState is unfortunately still needed.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg