From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgCwh-0004EN-NT for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:15:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgCwb-0005xa-As for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:15:19 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34897 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgCwb-0005xV-4f for qemu-devel@nongnu.org; Wed, 05 Dec 2012 06:15:13 -0500 Message-ID: <50BF2CBE.8070006@suse.de> Date: Wed, 05 Dec 2012 12:15:10 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1353185531-17042-1-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1353185531-17042-1-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_page_debug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov Cc: Igor Mammedov , qemu-devel@nongnu.org Am 17.11.2012 21:52, schrieb Max Filippov: > cpu_get_phys_page_debug is not in sync with cpu_x86_handle_mmu_fault: > the latter first checks CR0_PG_MASK and only after CR4_PAE_MASK. >=20 > This fixes odd gdb code display with PAE enabled. >=20 > Signed-off-by: Max Filippov You write, they are "not in sync". Would it be possible to share code to assure this, e.g., by calling a helper function from both? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg